-
Notifications
You must be signed in to change notification settings - Fork 85
Implement cache of device properties #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cache of device properties #2492
Conversation
include/alpaka/dev/DevCpu.hpp
Outdated
| std::shared_ptr<alpaka::DeviceProperties> m_deviceProperties; | ||
| std::shared_ptr<std::mutex> m_mutex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move these into the cpu::detail::DevCpuImpl class ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, done
|
@sbaldu The AMD CI runner has driver problems. I talk to the support. Don't care about the failed HIP runtime tests for the moment. |
28ff342 to
68c8a6a
Compare
68c8a6a to
e49e604
Compare
Ok thanks. I see that the rest of the tests are passing. |
The problem still exist. I'm on it. It takes a little bit longer, because the administrator is in vacations and I'm working together with another administrator which overtakes it temporary. |
|
@sbaldu Sorry, I did miss take. Your code has a bug. I can reproduce it locally. |
Ok thanks for the update. I'll fix it asap. |
309f1bd to
ef3a99a
Compare
de53bef to
c130965
Compare
|
Now I'm looking at parts of alpaka I never read before :-D I understand why you added the properties and flag to the From a semantic (?) point of view, something called a @psychocoderHPC what do you think ? |
|
Instead, from a more technical point of view, I would prefer to move more of the common code to a reusable function, to avoid repetitions. Could you try to move the For the CPU and CUDA/HIP cases it seems more complicated. |
c87afe2 to
b137daa
Compare
|
ok now all the tests seem to be passing. |
Changes approved in the weekly meeting
This PR caches the device properties once they have been accessed so as to reduce overheads for multiple consecutive calls.